Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): ignore private repositories (esp. backstage app, backend) when release plugins #1821

Merged
merged 1 commit into from
Nov 4, 2024
Merged

chore(ci): ignore private repositories (esp. backstage app, backend) when release plugins #1821

merged 1 commit into from
Nov 4, 2024

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Nov 4, 2024 •
edited
Loading

Hey, I just made a Pull Request!

This is a follow-up on #1510

It adds the missing changeset option privatePackages to new plugins so that their packages (backstage app and backend) are ignored when new releases are published.

  "privatePackages": {
    "tag": false,
    "version": false
  }

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@christoph-jerolimov
chore(ci): ignore private repositories (esp. backstage app, backend) …
57e0dc1 
…when release plugins

Signed-off-by: Christoph Jerolimov <[email protected]>
awanlin
awanlin approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this follow up @christoph-jerolimov 🚀

@christoph-jerolimov christoph-jerolimov self-assigned this Nov 4, 2024
@awanlin
Copy link
Contributor

awanlin commented Nov 4, 2024

Oh, is it safe for me to merge?

@christoph-jerolimov christoph-jerolimov merged commit 496302c into backstage:main Nov 4, 2024
20 checks passed
@christoph-jerolimov
Copy link
Member Author

All fine 🤗

@christoph-jerolimov christoph-jerolimov deleted the ignore-backstage-apps-and-backends-follow-up branch November 4, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awanlin awanlin awanlin approved these changes

@schultzp2020 schultzp2020 Awaiting requested review from schultzp2020 schultzp2020 is a code owner

Assignees

@christoph-jerolimov christoph-jerolimov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christoph-jerolimov @awanlin